Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_iothub_fallback_route #4965

Merged
merged 6 commits into from
Nov 27, 2019
Merged

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Nov 23, 2019

This PR finishes up the work done by @maxbog on #3679 and will close out #3303.

--- PASS: TestAccAzureRMIotHubFallbackRoute_basic (541.74s)
 --- PASS: TestAccAzureRMIotHubFallbackRoute_update (569.53s)

@katbyte katbyte added this to the v1.38.0 milestone Nov 26, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one comment LGTM 👍

MaxItems: 1,
Elem: &schema.Schema{
Type: schema.TypeString,
ValidateFunc: validate.NoEmptyStrings,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use validate.IoTHubEndpointName here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call

@mbfrahry mbfrahry merged commit 2750869 into master Nov 27, 2019
@mbfrahry mbfrahry deleted the f-iothub-fallback-route branch November 27, 2019 04:04
mbfrahry added a commit that referenced this pull request Nov 27, 2019
mbfrahry added a commit that referenced this pull request Nov 27, 2019
Update Changelog for #4965
@ghost
Copy link

ghost commented Dec 7, 2019

This has been released in version 1.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.38.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants